Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Add clean pattern #730

Merged
merged 2 commits into from
Jan 27, 2025
Merged

ci: Add clean pattern #730

merged 2 commits into from
Jan 27, 2025

Conversation

witwash
Copy link
Contributor

@witwash witwash commented Jan 27, 2025

Summary

It seems like the cleanup action is not deleting all those files it was supposed to delete. The dryrun would list the list of the affected files, but in the end, they are still there. No idea why. I've added the pattern argument, maybe this would make sure it works as it should.

As all removes are a bit risky, this one is a dryrun first. Then I'll remove the dryrun after I control it is not deleting anything it should not.

Testing steps

Info about test cases. If you think the issue is not testable, describe why.

Follow-up issues

Is there some action/cleanup needed after this PR is merged or deployed (e.g. consolidate some part outside the scope of this PR, etc)? Create issues for it with deadline and note them here and in the PR comments.

Check during review

  • Verify against Jira issue.
  • Is the PR over 300 additions? Consider rejecting it with advice to split it. Is it over 500 additions? It should definitely be rejected.
  • Unused code removed.
  • Build passing.
  • Is it a bug fix? Check that it is covered by a proper test (unit or integration).

@witwash witwash requested a review from a team as a code owner January 27, 2025 13:43
@witwash witwash changed the title Clean azure fix ci: Add clean pattern Jan 27, 2025
@witwash witwash enabled auto-merge (squash) January 27, 2025 13:43
Copy link
Contributor

@chaeMil chaeMil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@witwash witwash merged commit b6dfce2 into main Jan 27, 2025
7 checks passed
@witwash witwash deleted the clean-azure-fix branch January 27, 2025 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants